Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reject filter #1279

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Add reject filter #1279

merged 2 commits into from
Jul 9, 2020

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Mar 29, 2020

Summary

Proposed change:

Add reject filter to match Jinja2 behaviour.

Closes #282.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #1279 into master will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   89.60%   89.57%   -0.04%     
==========================================
  Files          22       22              
  Lines        3020     3030      +10     
==========================================
+ Hits         2706     2714       +8     
- Misses        314      316       +2     
Impacted Files Coverage Δ
nunjucks/src/node-loaders.js 65.67% <0.00%> (-2.99%) ⬇️
nunjucks/src/filters.js 96.24% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2031bf2...31b3dcf. Read the comment docs.

@ogonkov ogonkov changed the title Add reject filter WIP: Add reject filter Mar 29, 2020
@ogonkov
Copy link
Contributor Author

ogonkov commented Mar 29, 2020

It's better to merge it after #1278 since they almost the same.

@ogonkov ogonkov changed the title WIP: Add reject filter Add reject filter Apr 2, 2020
@ogonkov
Copy link
Contributor Author

ogonkov commented Apr 2, 2020

@fdintino now it's ready.

Codecov shows uncovered lines for file that is not in my PR for some reason

@ogonkov
Copy link
Contributor Author

ogonkov commented Apr 3, 2020

@fdintino Can you please trigger build in Travis for master it should fix coverage

@ogonkov
Copy link
Contributor Author

ogonkov commented Apr 13, 2020

@fdintino ?

nunjucks/src/filters.js Outdated Show resolved Hide resolved
@ogonkov ogonkov requested a review from fdintino April 21, 2020 14:07
nunjucks/src/filters.js Outdated Show resolved Hide resolved
@ogonkov ogonkov requested a review from fdintino April 21, 2020 14:54
@ogonkov
Copy link
Contributor Author

ogonkov commented Jun 12, 2020

@fdintino can we finish this Pull Request? :)

@fdintino
Copy link
Collaborator

@ogonkov : absolutely! My apologies though: it may not be for a week or two, at least. Only just got back to work from paternity leave, still managing remote work with a newborn and getting through a backlog of open source project maintenance.

@ogonkov ogonkov mentioned this pull request Jun 22, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement select/reject
3 participants