Broadened Windows precompile support to include strings #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }); | ||
|
|
||
| expect(fileName).to.not.contain('\\'); |
There was a problem hiding this comment.
why not make a stronger assertion about what the filename should be?
|
Updated with clearer assertions on resulting names. |
|
Can you add a changelog entry (in the 2.x section) with a link to this PR, like the existing entries? Thanks! |
|
Done. :) |
carljm
pushed a commit
that referenced
this pull request
Aug 31, 2016
* Broadened Windows precompile support to include strings * clearer assertions on resulting filenames * Updated changelog to include OS agnostic file paths in precompile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially created #761 to deal with incorrectly formatted paths, when precompiling in Windows. The original pull request only dealt with directories, this change also deals with strings.