This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
Check to make sure user owns group in displayer API #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the displayer API, we were neglecting to check if the group actually belonged to the specified user. While this isn't necessarily a security hole groups would still have to be marked as public to be shown it was certainly less than ideal.
|
@stenington to review (if possible). If you can't get to it by Friday, I'll just merge it. |
|
IT'S HAPPENING |
brianloveswords
added a commit
that referenced
this pull request
Nov 30, 2012
Check to make sure user owns group in displayer API [closes #420]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #420
In the displayer API, we were neglecting to check if the group actually
belonged to the specified user. While this isn't necessarily a security
hole – groups would still have to be marked as public to be shown – it
was certainly less than ideal.