Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a warning for unvalidated digital signatures in the generic viewer #13215

Closed
timvandermeij opened this issue Apr 10, 2021 · 2 comments · Fixed by #13217
Closed

Implement a warning for unvalidated digital signatures in the generic viewer #13215

timvandermeij opened this issue Apr 10, 2021 · 2 comments · Fixed by #13217

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Apr 10, 2021

In PR #13214 we implemented rendering digital signature annotations, but they are not validated yet. For mozilla-central we display the fallback bar with a clear warning that the signatures are not validated so the user is aware of this, but we have no such mechanism for the generic viewer yet.

I'm thinking we could implement something similar to the fallback bar, which might even be more generally useful for other kinds of messages we now display in the fallback bar. For mozilla-central we'd then use the current browser fallback bar, and for other targets we would display the PDF.js fallback bar instead.

Alternatively we could perhaps add a semi-transparent overlay over the signature.

@Snuffleupagus
Copy link
Collaborator

We could implement something similar to the fallback bar

The, by some margin, simplest solution as far as I'm concerned would be to just re-use the existing errorWrapper-functionality. While it obviously could look "better", it does the job well enough and requires virtually no "new" code; see master...Snuffleupagus:generic-signature-warn

@timvandermeij
Copy link
Contributor Author

timvandermeij commented Apr 10, 2021

Yes, that would work for now. It could be made to look better by styling the existing error wrapper a bit nicer, or perhaps allow the existing error wrapper to distinguish between warnings and error (errors in red, warnings in maybe a lighter color). In any case, for now something is definitely better than nothing, since we really want to make sure the end user is aware that the signatures are not validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants