Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Add fields for better identify onboarding user type #121

Closed
gasolin opened this issue Oct 27, 2017 · 6 comments
Closed

Add fields for better identify onboarding user type #121

gasolin opened this issue Oct 27, 2017 · 6 comments
Assignees
Milestone

Comments

@gasolin
Copy link
Collaborator

gasolin commented Oct 27, 2017

Related to Bug 1412164 - add new column for onboarding telemetry (client side work), we also need add columns in server side.

for firefox_onboarding_sessions_daily table,

  • add tour_type string column
    (valid string are new, update, default update)

for firefox_onboarding_events_daily table,

  • add timestamp column, (save event trigger time, same format as session_begin)
  • add tour_type string column
    (valid string are new, update, default update)
  • add tour_source string column
    (valid string are default, watermark, default default, its the same exists in firefox_onboarding_sessions_daily table)
  • add bubble_state string column (not send this data now, will append in following client update)
    (valid string are bubble, dot, hide, default bubble)
  • add notification_state string column (not send this data now, will append in following client update)
    (valid string are show, hide, finish, default show)

And we will add onboarding-icon-click event in firefox_onboarding_events_daily table, but I think it does not require column change

@gasolin
Copy link
Collaborator Author

gasolin commented Oct 27, 2017

@ncloudioj could you help on this?

@ncloudioj
Copy link
Member

@gasolin Sure, will do.

Also, just a reminder that once we add those new columns to the database, the existing data records will not have values for them (i.e. the value will be null). It might need some extra care when querying the database.

@gasolin
Copy link
Collaborator Author

gasolin commented Oct 30, 2017

got it, thanks for the notice

@gasolin
Copy link
Collaborator Author

gasolin commented Nov 2, 2017

related client code is landed into nightly https://bugzilla.mozilla.org/show_bug.cgi?id=1412164

@gasolin
Copy link
Collaborator Author

gasolin commented Nov 7, 2017

As discussion on slack, this database change might be delayed due to the database scale up, but should be able to catch up before 57 hits the road

@ncloudioj
Copy link
Member

@gasolin This is now fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants