Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Async/await for endStudy and submitEventPing #40

Closed
motin opened this issue May 3, 2018 · 0 comments · Fixed by #44
Closed

Async/await for endStudy and submitEventPing #40

motin opened this issue May 3, 2018 · 0 comments · Fixed by #44

Comments

@motin
Copy link
Contributor

motin commented May 3, 2018

These both invoke submitEncryptedPing which is async, thus they better be declared async themselves.
endStudy should probably also await this.uninstall() since it is declared async.

Issue found in mozilla/esper-pioneer-shield-study#26 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant