SRT parser crashes when file start with a blank line

[arnaudbreton]

Hi,

I've just started to use PopcornJS which is awesome to handle these many video providers!

I'm working with subtitles, in SRT format, from Coursera (http://coursera.org) and their subtitles start with a blank line.

When I parse this file, it crashes, line 63 (idx = time[1].indexOf( " " )).

Thanks for your help.

[cadecairos]

Thanks for reporting this issue @arnaudbreton!

I can confirm this bug. We now do all of our bug tracking using Bugzilla, and you can file new bugs here: https://bugzilla.mozilla.org/enter_bug.cgi?product=Webmaker&component=popcorn.js

I've gone ahead and filed this issue on the popcorn.js component in bugzilla for you (https://bugzilla.mozilla.org/show_bug.cgi?id=864765), but please do file new bugs there if you come across any other issues.

Once again, thanks for reporting! :D 👍

[arnaudbreton]

Hi,

Sorry, I was not aware of that. I will do it for sure next time!
Thanks for reporting this issue for me.

You're welcome, this library is just amazing and make things very easier!
Great job!