Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Resize issues when navigation is open #902

Open
alexgibson opened this issue Oct 17, 2023 · 2 comments
Open

[docs] Resize issues when navigation is open #902

alexgibson opened this issue Oct 17, 2023 · 2 comments
Labels
Bug 🪲 Something isn't working

Comments

@alexgibson
Copy link
Member

Description

Not entirely sure if this is just the way fractal works, but if you resize the browser window when the documentation side navigation is open, the content gets cut off

image

Steps to reproduce

  1. In a desktop browser, open https://protocol.mozilla.org/
  2. Make sure the navigation side menu is open
  3. Resize the browser window to < 758px wide.

Expected result

Page content should be visible.

Actual result

Page content is obscured.

Environment

Reproducible in any desktop browser.

@alexgibson alexgibson added the Bug 🪲 Something isn't working label Oct 17, 2023
@janbrasna
Copy link
Contributor

There are some offending lines that make it better when omitted:
Screen Shot 2023-12-25 at 22 58 28

Given the flex reorder & 3d transformation to hide the menu and move the content I believe the correct value there was supposed to be -240px instead of 240px — then the layout seems as intended:
Screen Shot 2023-12-25 at 23 00 49

I'll investigate where that comes from…

@janbrasna
Copy link
Contributor

Traced it to https://github.com/frctl/fractal/blob/dd6cd938653b24cd23456d10b9c28d3bc436c4c3/packages/mandelbrot/assets/scss/core/_mixins.scss#L136C43
where it should be $value * -1 or https://github.com/frctl/fractal/blob/dd6cd938653b24cd23456d10b9c28d3bc436c4c3/packages/mandelbrot/assets/scss/components/_frame.scss#L29 where the argument should be $width-sidebar * -1

That's definitely Fractal/mandelbrot bug as you can reproduce that with the currently published demo as well: https://demo.fractal.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants