fix clz32 rounding errors #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbri
added a commit
to HtmlUnit/htmlunit-rhino-fork
that referenced
this pull request
Dec 30, 2023
rbri
added a commit
to HtmlUnit/htmlunit-rhino-fork
that referenced
this pull request
Dec 30, 2023
Pull Request mozilla#1430: fix clz23 rounding errors
|
Do you know if there's a test from test262 or anything that can verify this? For example, there is a "math-clz32.js" file in the V8 codebase, but it seems much different than this. I'm sure that this is right but I'd feel better if we had a reference. |
yes, found the same while preparing this |
Will have another look but i think i can't spend so much time on this and running all the samples in the browser proof that this is correct. |
Merged
andreabergia
added a commit
to andreabergia/rhino
that referenced
this pull request
Jan 15, 2024
|
OK - I think we're in good shape here then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use bit logic to avoid rounding errors (based on HtmlUnit#10)