Fix Math.atanh
#1438
Merged
Fix Math.atanh
#1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabergia
force-pushed
the
fix-atanh
branch
from
db95a68
to
decb266
Compare
rbri
reviewed
Jan 15, 2024
| @@ -153,7 +153,7 @@ private static Object atanh(Context cx, Scriptable scope, Scriptable thisObj, Ob | |||
| } | |||
| return ScriptRuntime.negativeZeroObj; | |||
| } | |||
| return Double.valueOf(0.5 * Math.log((x + 1.0) / (x - 1.0))); | |||
| return Double.valueOf(0.5 * Math.log((x + 1.0) / (1.0 - x))); | |||
There was a problem hiding this comment.
maybe pedantic but to be in sync with MDN
return Double.valueOf(0.5 * Math.log((1.0 + x) / (1.0 - x)));
| @@ -54,4 +54,78 @@ assertEquals(Math.imul(-2, -2), 4); | |||
| assertEquals(Math.imul(0xffffffff, 5), -5); | |||
| assertEquals(Math.imul(0xfffffffe, 5), -10); | |||
|
|
|||
| assertEqualsDelta(Math.atanh(1/2), 0.549306144334059, 0.0000000000001); | |||
There was a problem hiding this comment.
because the 262 tests suite seems to have no tests for this maybe you can add some more samples
| assertEquals(Math.sign('foo'), NaN); | ||
| assertEquals(Math.sign(), NaN); | ||
|
|
||
| assertEquals(Math.clz32(0), 32); |
There was a problem hiding this comment.
There is a separate PR #1430 for clz32, maybe we have to merge the two different approaches of tests for the functions
There was a problem hiding this comment.
I've removed all the cases from this file - it seems the other PR will add complete coverage
rbri
approved these changes
Jan 17, 2024
|
Looks good to me, and nice catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1437
I have added also some tests for various "recent" math functions that seemed to be lacking them.