Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make ToNumber(String) conversion more spec-compliant #383
Update ToNumber conversion applied to the String type:
New behavior is applied only if the language version is >=ES6, so it
This also enables built-ins/Number test262 cases.
I’ve also verified that the new
I have one question related to this.
I decided to not change the tests that cover some non-spec’ed functionality in MozSuite, which leaves it on the language version < ES6. Is it ok?
Looks good to me -- I understand what you did to this complex code and I see that it's tested and works for my simple tests as well.
Curious if anyone else has also inspected this.
I do think it's safest to leave this to ">=ES6" for now since backward compatibility can show up at the worst time!
Jan 31, 2018
1 check passed
Thanks for merging!
Sure, let’s leave it for now.
It’s just that I’m a bit concerned it may become harder to update in future if we drift away too much. Maybe create an issue to keep track of it?