Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support indexed accessor properties in Object Literals #908

Merged
merged 3 commits into from
May 25, 2021

Conversation

p-bakker
Copy link
Collaborator

@p-bakker p-bakker commented May 23, 2021

Adds support for indexed accessor properties.

Without this, running the the current master of Test262 hangs on https://github.com/tc39/test262/blob/main/test/built-ins/Array/prototype/concat/arg-length-near-integer-limit.js, as the getter for index 0 is never called

Closes #906
Closes #775

@gbrail
Copy link
Collaborator

gbrail commented May 25, 2021

Thanks for the timely fix!

This method has a ton of undocumented prerequisites that predate your fix -- it assumes that the index is either a String or an Integer, for example. I think that's fine since it's tightly embedded with the interpreter and code generation.

@gbrail gbrail merged commit 81346d3 into mozilla:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get doesnt work for indexed properties Calling to getter/setter method incorrectly
2 participants