Remove test that checks whether toUpperCase returns the same character #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as lowerCase character if Unicode defines that there's no uppercase variant The tests break on Windows, because windows uses the latest Unicode standard, while Unix doesn't and in Unicode 11 some Georgian characters that were previously only available in lowercase have now received an uppercase variant So, this test would either fail on Windows or if fixed (because EcmaScript states to use the latest UniCode standard) would break on Linux. That said, the test basically tests whether the OS on which Rhino runs is providing the proper Unicode data to Java and whether Java handles this correctly. so it's not really testing anythign specific in the Rhino implementation
|
I think it's fine to delete this test, since as you point out it just tests that Java works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as lowerCase character if Unicode defines that there's no uppercase
variant
The tests break on Windows, because windows uses the latest Unicode
standard, while Unix doesn't and in Unicode 11 some Georgian characters
that were previously only available in lowercase have now received an
uppercase variant
So, this test would either fail on Windows or if fixed (because
EcmaScript states to use the latest UniCode standard) would break on
Linux.
That said, the test basically tests whether the OS on which Rhino runs
is providing the proper Unicode data to Java and whether Java handles
this correctly. so it's not really testing anythign specific in the
Rhino implementation