Extract the Object.seal/freeze/isSealed/isFrozen logic, fixing a few bugs in the process #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugs in the process - all operations now properly take Symbols into account - getOwnPropertyDescriptor for length property of array properly represents state - proper handling of attempt to update length property on frozen array
gbrail
reviewed
Jun 5, 2021
|
From my POV this branch is now ready to merge |
|
LGTM for me too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #243 the logic to freeze an object needs to be accessible from Java code
This PR extracts the internal logic of Object.seal/freeze/isSealed/isFrozen to the abstract object operations testIntegrityLevel & setIntegrityLevel as defined by EcmaScript, as on that level the logic needs to be reused in Tagged Template Literals
In the process, the following issues were encountered and fixed:
.defineOwnProperty(Context cx, Object key, ScriptableObject desc)instead of.defineOwnProperty(Context cx, Object key, ScriptableObject desc, boolean checkValid), causing it's logic to never be triggers when Rhino code calls the later overload directly