Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the Object.seal/freeze/isSealed/isFrozen logic, fixing a few bugs in the process #922

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Extract the Object.seal/freeze/isSealed/isFrozen logic, fixing a few bugs in the process #922

merged 4 commits into from
Jun 7, 2021

Commits on Jun 3, 2021

  1. Extract the Object.seal/freeze/isSealed/isFrozen logic, fixing a few 

    bugs in the process

- all operations now properly take Symbols into account
- getOwnPropertyDescriptor for length property of array properly
represents state
- proper handling of attempt to update length property on frozen array
    @p-bakker
    p-bakker committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    1fbd915 View commit details
    Browse the repository at this point in the history

  2. checkStyle fix

    @p-bakker
    p-bakker committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    228c75f View commit details
    Browse the repository at this point in the history

  3. Spotless formatting

    @p-bakker
    p-bakker committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b974ea0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Code Review comments, fix for Arrays, better docs

    @p-bakker
    p-bakker committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    a6dbead View commit details
    Browse the repository at this point in the history