Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider replacing '&Store' with 'Store' in the function calls #87

Closed
ncloudioj opened this issue Nov 20, 2018 · 0 comments · Fixed by #88
Closed

Consider replacing '&Store' with 'Store' in the function calls #87

ncloudioj opened this issue Nov 20, 2018 · 0 comments · Fixed by #88

Comments

@ncloudioj
Copy link
Member

Since type Store is essentially Copy-able, all its occurrences in the function calls could be passed by value instead of by reference.

It'll be consistent with the API definitions in LMDB. Clippy also suggests this change for the efficiency purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace all the passed-by-reference with passed-by-value for Store ncloudioj/rkv
1 participant
@ncloudioj