Skip to content
This repository has been archived by the owner on Sep 15, 2021. It is now read-only.

execute the scan.js bits in a worker? #7

Closed
mozfreddyb opened this issue Feb 28, 2014 · 3 comments · Fixed by #43
Closed

execute the scan.js bits in a worker? #7

mozfreddyb opened this issue Feb 28, 2014 · 3 comments · Fixed by #43
Assignees
@mozfreddyb
Labels
enhancement web client
Milestone
1.0

Comments

@mozfreddyb
Copy link

Very large scripts give me the "Stop Script?" dialog, and rightfully so.
We could do the whole script scanning in a worker.
This was referenced Mar 6, 2014
Closed
Closed
@pwnetrationguru
Copy link

I agree with doing this.

Would also be nice if we could get some sort of loading animation so the user knows Scan.js is grinding while they are waiting.

@mozfreddyb mozfreddyb self-assigned this Mar 7, 2014
@mozfreddyb mozfreddyb added bug and removed bug labels Mar 7, 2014
@mozfreddyb mozfreddyb added this to the 0.1 milestone Mar 7, 2014
@mozfreddyb
Copy link
Author

I'm not sure if we should get this into 0.1, but I think it might be doable :)

@pwnetrationguru
Copy link

I think it's pretty important and I agree doable! :)

@mozfreddyb mozfreddyb mentioned this issue Mar 11, 2014
Merged
pwnetrationguru pushed a commit that referenced this issue Mar 11, 2014
Merge pull request #43 from mozilla/scan-in-worker
61a1cd4 
perform scanning in a worker, fixes #7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mozfreddyb mozfreddyb

Labels
enhancement web client
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

perform scanning in a worker, fixes #7 mozilla/scanjs
2 participants
@pwnetrationguru @mozfreddyb