This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #7 and moves all scanning into a worker
scanworker.js
:I had to change rules.js so that it doesn't require ScanJS to be loaded in the same scope (it's in the worker now!). We might want to solve this differently, if you guys don't like the current workaround.
I hope this request doesn't break pull request #42, otherwise I can happily rebase either.