Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix arm64 builds #1782

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Attempt to fix arm64 builds #1782

merged 2 commits into from
Jun 1, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (93e846f) 29.38% compared to head (1946c11) 29.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   29.38%   29.36%   -0.02%     
==========================================
  Files          49       49              
  Lines       17713    17713              
  Branches     8548     8548              
==========================================
- Hits         5205     5202       -3     
- Misses       7341     7342       +1     
- Partials     5167     5169       +2     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alex
Copy link
Contributor Author

alex commented Jun 1, 2023

Looks like the sed hijinx fix it, yay!

Hopefully this will enable restoring the aarch64 release binaries.

@sylvestre
Copy link
Collaborator

sed programming, the best kind!

@sylvestre sylvestre merged commit be7f960 into mozilla:main Jun 1, 2023
@alex alex deleted the patch-1 branch June 1, 2023 22:48
@alex
Copy link
Contributor Author

alex commented Jun 1, 2023

Thanks! Any chance of getting a release with the aarch64 builds? Those are the last hurdle for us.

@sylvestre
Copy link
Collaborator

@alex
Copy link
Contributor Author

alex commented Jun 3, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants