Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

Embedded tweets not working on the blog #531

Open
abbycabs opened this issue Jul 12, 2016 · 13 comments
Open

Embedded tweets not working on the blog #531

abbycabs opened this issue Jul 12, 2016 · 13 comments
Milestone

Comments

@abbycabs
Copy link
Contributor

They show up on the wordpress instance: https://mozscienceblog.wpengine.com/?p=3657
screen shot 2016-07-12 at 11 36 04

But not on the site:
https://science.mozilla.org/blog/why-developing-oss-matters

screen shot 2016-07-12 at 11 36 27

@abbycabs abbycabs added this to the Blue Sky milestone Jul 12, 2016
@auremoser
Copy link
Contributor

+1 to this, noted it for Anna's ISBE guest blog last week.

@alanmoo
Copy link
Contributor

alanmoo commented Sep 17, 2016

I think this might be due to the way WordPress exports HTML. There is a class we can use to recreate the styling, but it wouldn't be locked to Twitter's unless they offer a stylesheet I'm not aware of (which is totally possible).

@hannahkane hannahkane modified the milestones: Phase 2.1, Blue Sky Sep 26, 2016
@hannahkane
Copy link

As noted in roadmap doc, this is less important than other blog issues, given there's a workaround

@alanmoo
Copy link
Contributor

alanmoo commented Sep 29, 2016

By workaround, you mean some hardcoded CSS? I've got those in #555

@hannahkane
Copy link

Workaround is uploading a screenshot, I believe

@alanmoo
Copy link
Contributor

alanmoo commented Sep 29, 2016

That has some serious accessibility issues. @acabunoc How is this as a workaround?

@abbycabs
Copy link
Contributor Author

<3 much better! @alanmoo

@alanmoo
Copy link
Contributor

alanmoo commented Oct 4, 2016

Should we close this/change it now that #555's landed? The current implementation doesn't give complete tweet details (like conversation) but does get the tweet itself- example

@abbycabs
Copy link
Contributor Author

abbycabs commented Oct 4, 2016

hey @alanmoo, the tweets in this post aren't formatted, are they embedded wrong? https://science.mozilla.org/blog/2016-isbe-review

@auremoser
Copy link
Contributor

+1 to what abby said, I'm find with the single card view that @alanmoo linked to as an example, but we should document the correct embed format somewhere so it doesn't default to this:
screen shot 2016-10-04 at 10 48 15 am

@alanmoo
Copy link
Contributor

alanmoo commented Oct 4, 2016

@acabunoc @auremoser I'm not sure how they were originally embedded (was the whole post copied and pasted from somewhere?) but if you paste a tweet link into the WordPress editor, it pulls in the tweet and will style it as in the previous example.

@auremoser
Copy link
Contributor

Twitter has an "embed" generated iframe that it offers, I believe the unformatted tweets use that, because I think I assumed that you would need to embed a tweet and it wouldn't just generate formatting. Good to know, I'll update the post and test. :)

@alanmoo
Copy link
Contributor

alanmoo commented Oct 4, 2016

Yeah, this is kind of an intermediate step towards using that, but it was a quick and easy solution that looks good enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants