Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename starts_*_flow to is_*_flow #1693

Merged
merged 1 commit into from
Feb 18, 2014
Merged

Rename starts_*_flow to is_*_flow #1693

merged 1 commit into from
Feb 18, 2014

Conversation

lpy
Copy link
Contributor

@lpy lpy commented Feb 14, 2014

see #1692

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/789

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @jdm (or someone else) soon.

@highfive
Copy link

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @lpy, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

bors-servo pushed a commit that referenced this pull request Feb 18, 2014
@bors-servo bors-servo merged commit 280b109 into servo:master Feb 18, 2014
@lpy lpy deleted the issue1692 branch February 19, 2014 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants