Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename generated XPI file instead of creating a sym-link? #42

Closed
pdehaan opened this issue Dec 11, 2017 · 3 comments
Closed

Rename generated XPI file instead of creating a sym-link? #42

pdehaan opened this issue Dec 11, 2017 · 3 comments

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Dec 11, 2017

Per mozilla/addon-wr#17

Instead of generating a symbolic link to the generated XPI, why not just do a mv "${XPI_NAME}" addon.xpi? (Or even mv *.xpi addon.xpi, if the /dist/ directory only has one XPI file)

https://github.com/gregglind/addon-wr/blob/526535ea04ce79f59a79381ab71b8c9be61b9af8/bin/xpi.sh#L39-L49
@pdehaan pdehaan mentioned this issue Dec 11, 2017
Closed
@motin
Copy link
Contributor

motin commented Feb 13, 2018

Keeping the filename intact (with guid and version) is important to be able to be sure that we submit the correct xpi for signing and deployment.
The dist directory will over the lifetime of developing addons contain builds of all the different versions built by the developer.

@motin
Copy link
Contributor

motin commented Jun 20, 2018

Related: #75

@motin
Copy link
Contributor

motin commented Mar 2, 2019

Closing as wontfix

@motin motin closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdehaan @motin