Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SOPS_AGE_KEY environment variable #1006

Merged
merged 4 commits into from
Mar 1, 2022

Conversation

choffmeister
Copy link
Contributor

This PR adds support for passing Age keys directly via environment variable SOPS_AGE_KEY. This increases ease of use as well as increases security as one can often pass the key directly in memory instead of having to write it to disk first.

@ajvb
Copy link
Contributor

ajvb commented Feb 23, 2022

@choffmeister Thank you for the PR! Can you change the PR to be against the develop branch?

(The fact that tests are failing is because of something fixed in develop)

@choffmeister choffmeister changed the base branch from master to develop February 24, 2022 09:11
@choffmeister
Copy link
Contributor Author

@ajvb Hi there. I have merged develop into this branch and changed the PR base branch to develop.

Copy link
Contributor

@ajvb ajvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some small nits.

age/keysource.go Show resolved Hide resolved
age/keysource.go Outdated Show resolved Hide resolved
age/keysource_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants