Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of client_id and use a hashed telemetry ID #117

Closed
crankycoder opened this issue Oct 10, 2018 · 3 comments
Closed

Remove all uses of client_id and use a hashed telemetry ID #117

crankycoder opened this issue Oct 10, 2018 · 3 comments

Comments

@crankycoder
Copy link
Contributor

The telemetry ID is being deprecated in favor of a sha256 hashed ID.

Rename variables from client_id toclient_hash in taar for clarity.

Update all ETL jobs in python_mozetl related to TAAR to compute and use hashes instead of raw telemetry client ID.

@crankycoder
Copy link
Contributor Author

Coordinate with @ddurst regarding the particular HTTP header naming and encoding of the sha hash

@crankycoder
Copy link
Contributor Author

crankycoder commented Nov 7, 2018

This code has landed in python_mozetl as of mozilla/python_mozetl#267

The relevant patch on the TAAR application code to convert from a UUID to a hashed telemetry ID is included in #128

See line:

@app.route("/v1/api/recommendations/<hashed_client_id>/", methods=["GET", "POST"])

@crankycoder
Copy link
Contributor Author

Hashed client ID landed in f279c25.

Tests were updated in 32a3e64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant