Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Newsletter submission should include a "source_url" parameter #2392

Closed
pmac opened this issue Apr 20, 2017 · 4 comments
Closed

Newsletter submission should include a "source_url" parameter #2392

pmac opened this issue Apr 20, 2017 · 4 comments
Assignees
@lmorchard
Labels
good first issue
Milestone
Sprint 24

Comments

@pmac
Copy link
Member

pmac commented Apr 20, 2017 •
edited by ghost
Loading

The email marketing team would very much appreciate you adding this parameter. It'd be best to send the value as the current URL of the page, but if you'd rather hard-code "https://testpilot.firefox.com/" that works for us as well.
@ScottDowne
Copy link

Hey all, figured I would pick up another few small bugs while I had some time between campaigns.

I used the hard coded url because that's what I've used with my previous basket interactions, but happy to change it to something along the lines of window.location.origin + window.location.pathname or something else.

Thoughts?

@pmac
Copy link
Member Author

pmac commented May 1, 2017

👍 from me. It might be best and more future proof to use the window.location.* values, but this is better than what we have and is probably more robust. Are there multiple URLs at which the newsletter form currently lives on testpilot.f.c?

lmorchard added a commit that referenced this issue May 2, 2017
@lmorchard
Merge pull request #2404 from ScottDowne/basket-source-url
b29f59e 
Fixes: #2392 Adding source_url to basket newsletter submissions.
@lmorchard
Copy link
Contributor

The newsletter form lives in the footer on all pages of Test Pilot, but I'm not sure we're all that worried about getting granular

@pmac
Copy link
Member Author

pmac commented May 2, 2017

The email marketing team is pretty worried about it from what I understand, but this is a step forward. Thanks!

lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
7c2a424 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
5f7bf66 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
f4ac9bf 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
55b0d90 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
190d25b 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
bce4f96 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
b300db4 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
fff509f 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
@lmorchard lmorchard mentioned this issue May 3, 2017
Merged
@lmorchard lmorchard self-assigned this May 3, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
5d67b6b 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 3, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
d3517b8 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation (mozilla#1758)

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 5, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
4a8e491 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation (mozilla#1758)

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
@ghost ghost modified the milestone: Sprint 23 May 6, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue May 15, 2017
@lmorchard
Switched to shared NewsletterForm in EmailDialog
ec912e3 
- Rework `frontend/src/app/components/EmailDialog` to use
  `NewsletterForm` instead of local form implementation (mozilla#1758)

- Add failure state to `EmailDialog`

- CSS tweaks for `NewsletterForm` when used in a dialog

- Drop lang parameter from Basket POST (mozilla#2403)

- Use window.location as source parameter for Basket POST (mozilla#2392)

- Move `subscribeToBasket` to shared `app/lib/utils`

- Deleted some now unused strings

- Updated tests to reflect all the above

Fixes mozilla#1758.
Fixes mozilla#2392.
Fixes mozilla#2403.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmorchard lmorchard

Labels
good first issue
Projects
None yet
Milestone
Sprint 24
Development

No branches or pull requests
3 participants
@lmorchard @ScottDowne @pmac