Bug 1310974 - Perform autoclassification after crossreferencing error lines #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lines In the short term this change is a small negative as it will slow down autoclassification tasks. However it's a necessary step to future changes that will put the autoclassification results on the text log error table and allow autoclassification of non-structured lines. As part of this, we remove the use of callback tasks and just schedule the crossreference task to run after the parser tasks. This is simpler and reflects the fact that we only schedule one parser task at a time now.
jgraham
force-pushed
the
autoclassify_after_crossreference
branch
from
e45de22
to
04a8255
Compare
edmorley
reviewed
Oct 26, 2016
|
|
||
|
|
||
| @retryable_task(name='crossreference-error-lines', max_retries=10) | ||
| def crossreference_error_lines(job_id): | ||
| def crossreference_error_lines(job_id, priority): |
There was a problem hiding this comment.
This needs to be priority=None for backwards compatibility with any already-queued tasks at the time this is deployed.
There was a problem hiding this comment.
It's not quite that simple. Bug 1310972 still hasn't landed on prod so we have backwards incompatible changes to the queues in any case. Given that it's not clear that adding a falback here is helpful.
There was a problem hiding this comment.
If these are going to land together as part of the "stopping ingestion" plan, then that sounds fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the short term this change is a small negative as it will slow down
autoclassification tasks. However it's a necessary step to future
changes that will put the autoclassification results on the text log
error table and allow autoclassification of non-structured lines.
As part of this, we remove the use of callback tasks and just schedule
the crossreference task to run after the parser tasks. This is simpler
and reflects the fact that we only schedule one parser task at a time
now.
This change is