Update to Twemoji v11.4.0. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually meant to link https://emojipedia.org/emoji-11.0/, which tests more of the new ones since it does the combos as well as the standalone ones. |
|
Please also update the version in |
|
@TheEssemCraft Could you help review the changes? |
|
Perhaps also land this on Firefox? |
Thanks, done!
I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1470107, and I'll submit a patch if and when this is merged. |
|
what about updating to v11.2? |
Silences a warning during make: "WARNING: Table version value is a float: 1.0000; fix to use hex instead: 0x00010000"
Fixes mozilla#34. ZIP file was made by running `for file in $(find ./svg | sort) ; do zip -9 -q twe-svg.zip $file ; done` rather than a simple zip since it makes the comparison report more sensibly ordered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
Is there anything in particular to do to test this to make sure it's okay?
I replaced the browser/fonts/TwemojiMozilla.ttf in Firefox and rebuilt it, loaded https://emojipedia.org/unicode-11.0/ and saw all the new ones seem to display fine.