78 add platform styles

[kaganjd]

No description provided.

[chuckharmston]

This little bit in the diff:

Means that there's no newline at the end of the file. Would you mind adding that for all the CSS files you added?

[chuckharmston]

This is really fantastic work. Great job, @kaganjd! If you wouldn't mind addressing the few nits above and squashing into one commit, I'd be happy to merge this.

[jaredhirsch]

@kaganjd I'm not sure we want to use '@import' because we'll need to manually unload the stylesheets when the addon is disabled/uninstalled.

Would you mind manually loading / unloading both the main style.css file and the platform-specific files?

[jaredhirsch]

@kaganjd Ok, getting close! Once the loading and unloading covers both stylesheets, we'll do a final syntax pass and land this thing. Nice work :-)

[jaredhirsch]

@kaganjd Sorry, I didn't explain this correctly. I think you want to make sure your editor is inserting newlines at the end of files by default.

Here's a great article from Thoughtbot that explains the historical motivation for this convention, and how to configure common editors like vim and emacs: https://robots.thoughtbot.com/no-newline-at-end-of-file

[jaredhirsch]

@kaganjd OK, we're nearly done, great job. This pass probably looks like a ton of comments, but I really just wanted to hit all the minor details in a single round. Once you've made these changes, it'll be good to land (though I'll take a last glance to be sure).

Please feel free to ask questions, and ping me when this is ready for a final review. :-)

[jaredhirsch]

@kaganjd We actually don't want semicolons at the end of CSS blocks, we just want the closing bracket. Here's some discussion on MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/Syntax#CSS_declarations_blocks

[jaredhirsch]

@kaganjd Nice work! Remove the trailing semicolons from the CSS files, re-push, and I'll hit the big green button 🎉

[kaganjd]

cool! done, i think. fingers crossed

[jaredhirsch]

@kaganjd Looks good! One more thing: you need to squash your 5 commits into a single commit, and reword the commit message. This shouldn't take too long:

• git rebase -i HEAD~5 will open up interactive rebase mode, it'll initially look like this:

- squash the commits together by leaving the 'pick' at the front of the top line, and for the 4 lines below it, replace the 'pick' with 's' (for squash):

- save and exit out of the editor to rebase, git will jump to the command line while rebasing, then you'll jump back to an editor window that shows all the commit messages:

I think the initial commit message was great, you just need to add a "Fixes #78" on a new line, something like this should work, note that present tense is used though:

So, squash your commits, push once more, and I'll land the patch for you. Great work ^_^

Background reading, in case you're interested:

• interactive rebase: nice article on git ready, http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
• good advice on commit message style: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

edited to linkify tbaggery link