fix(deps): fixed yargs import for yarn 3.x + pnp

[leaumar]

fixes #2332 , process of arriving at this change documented there

I did not make this change out of some sort of expertise in js dependency loading mechanisms, but by trial and error and eliminating the odd one out. I did however test this change in my personal project by modifying the downloaded npm artifact's code in the same way, and I ran npm test in this repo after this change too. If I understand the author's comment right, this change can't be harmful.

I'm willing to put in more time to work with you on proving this change fixes something, but please reach out with instructions then. I'll give you a live demo via a discord call if you want, or a repo to reproduce it on (which is already linked in the issue).

[codecov]

Codecov Report

Merging #2348 (13c0446) into master (19fdd3a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2348   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          32       32           
  Lines        1699     1699           
=======================================
  Hits         1697     1697           
  Misses          2        2           

Impacted Files	Coverage Δ
src/program.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19fdd3a...13c0446. Read the comment docs.

[rpl]

@leaumar lgtm, it looks that we can now also remove that $FlowFixMe and related todo comments, I also confirmed locally that the flowtype checks are passing just fine without that now. Would you mind to remove line 9 and 10 in this PR? (if you can't, don't worry, I can take care of that in a separate patch).

As I have also expressed in the issue comments, thank you for having looked into how to fix this.

[leaumar]

I'll push that in a minute, no prob.

I feel we should forward this issue to the yargs devs too, since the cause is an inconsistency in their exports and there may be other middle projects breaking on this. I'll just go ahead and refer them here?

[leaumar]

Do the current changes on master since the last release permit a speedy patch release btw? Would love this to be rolled out asap if possible.

[rpl]

Do the current changes on master since the last release permit a speedy patch release btw? Would love this to be rolled out asap if possible.

I was already planning to release a minor version soon enough (I've been a bit busy, but I should be able to get to it at least by next week) and merging on master PRs that fit in what I consider ok for a minor version. This applies too.

[rpl]

I'll push that in a minute, no prob.

I feel we should forward this issue to the yargs devs too, since the cause is an inconsistency in their exports and there may be other middle projects breaking on this. I'll just go ahead and refer them here?

sure, feel free to go ahead and report it to yargs, it is possible that there may be reasons that we may be missing or to be something that would be at least worth to document more explicitly in the yargs docs or README, either case yargs maintainers will know if they feel that is something they want to follow up to on their side or not.

[leaumar]

Alright, thanks. Is gonna feel good to stop waking up to tons of CI failure emails every morning after Renovate rebases all the failing dependency bump PRs. 😛