fix: disabled caching during npm run lint #434
Conversation
|
This is off to a great start, thanks. I verified that the I went back and re-read the issue and remembered the main thing we need is for npm start to use The npm start command is an alias for grunt develop which calls the subtask watch:develop. This task is configured to call grunt lint but it should instead call As for grunt test, this command should not use the eslint cache (I was mistaken about that). This command runs once and exits so it's not important to use the cache. |
|
Thanks for the feedback! I will make the specified changes and open a new PR. |
| @@ -35,7 +35,7 @@ module.exports = function(grunt) { | |||
| grunt.registerTask('test', [ | |||
| 'build-tests', | |||
| 'mochaTest', | |||
| 'lint', | |||
| 'eslint', | |||
There was a problem hiding this comment.
this can continue to call the lint task, it's the same thing
| @@ -48,12 +48,9 @@ module.exports = function(grunt) { | |||
| grunt.registerTask('lint', 'checks for syntax errors', function() { | |||
| if (process.env.SKIP_LINT) { | |||
| grunt.log.writeln('lint task skipped because of $SKIP_LINT'); | |||
| } else if (semver.satisfies(process.version, '< 4.0.0')) { | |||
There was a problem hiding this comment.
At the top of the file, you can now remove the line that requires the semver module. The lint command in the test suite caught this error for you :) Also, you can now remove semver from package.json because it's not used anywhere else.
|
Thanks for all the fix-ups. |
Fixes #339
The
.cachedirectory is no longer created while runningnpm run lint