fix: firefox binary path not passed in the run method exported by 'src/firefox/index' #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpl
force-pushed
the
fix/run-custom-firefox-binary-Path
branch
from
6bc8846
to
48bbd7b
Compare
| @@ -333,6 +333,6 @@ export class ExtensionRunner { | |||
|
|
|||
| run(profile: FirefoxProfile): Promise<FirefoxProcess> { | |||
| const {firefoxApp, firefox} = this; | |||
| return firefoxApp.run(profile, {firefox}); | |||
| return firefoxApp.run(profile, {firefoxBinary: firefox || null}); | |||
There was a problem hiding this comment.
does this need to pass null to satisfy the flow type or something? Could it just be {firefoxBinary: firefox} ?
There was a problem hiding this comment.
@kumar303 yep, it was a small leftover.
Removed in the updated patch.
|
r+wc (with comments). I just had one question about passing |
…c/firefox/index'.
rpl
force-pushed
the
fix/run-custom-firefox-binary-Path
branch
from
48bbd7b
to
2ecc55e
Compare
|
@kumar303 the change suggested in the above comment has been applied and this pull request updated accordingly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the optional Firefox binary path option and contains some tweaks to the related declared flow types, which shows how we can force flow to raise errors on this kind of issues (missing optional parameters in the
parametersandoptionsobjects)