Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show an error if an argument is passed to the lint command #474

Merged
merged 1 commit into from
Sep 8, 2016

Conversation

shubheksha
Copy link
Contributor

Fixes #398
Also added a test for checking if an argument is passed to a sub-command.

@coveralls
Copy link

coveralls commented Sep 8, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 7ceff07 on shubheksha:fix/398 into 45d9c0d on mozilla:master.

@kumar303
Copy link
Contributor

kumar303 commented Sep 8, 2016

looks great, thanks!

I think one day we might create a command that requires an argument. But that day may never come ;) We can make this more configurable if the day does come.

@kumar303 kumar303 self-assigned this Sep 8, 2016
@kumar303 kumar303 merged commit a25c04f into mozilla:master Sep 8, 2016
@atsay
Copy link

atsay commented Sep 8, 2016

Yay! I've noted your contribution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants