common, response: add window state to window rect response

[andreastt]

The WebDriver specification recently introduced an additional "state"
field for the window rect.

---

This change is 

[jgraham]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/common.rs, line 227 at r1 (raw file):

///
/// [`normal`]: #variant.Normal
#[derive(RustcEncodable, Debug)]

Why RustcEncodable?

---

Comments from Reviewable

[andreastt]

Why RustcEncodable?

This isn’t needed. Dropped.

[jgraham]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[whimboo]

@andreastt, this change makes geckodriver fail to compile on central now. Is there a bug which covers updating geckodriver?

[andreastt]

@whimboo geckodriver doesn’t fail to compile on m-c because geckodriver is pinned to 0.28.0. This introduces some API changes which needs to be addressed next time it upgrades it dependencies…

[whimboo]

Ok, bad wording on my side. Due to my work for proxy and other related changes I have to work with the current webdriver-rust code. As such I cannot use the version from crates.io. It would be great if you can do this upgrade on m-c.

[andreastt]

Sure thing! I’ve submitted some patches for this in https://bugzilla.mozilla.org/show_bug.cgi?id=1388365.