Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

Brick - Text Definition #23

Closed
thisandagain opened this issue Jul 30, 2014 · 9 comments
Closed

Brick - Text Definition #23

thisandagain opened this issue Jul 30, 2014 · 9 comments
Milestone

Comments

@thisandagain
Copy link
Contributor

No description provided.

@thisandagain thisandagain added this to the Design Refinements milestone Jul 30, 2014
@mhanratty
Copy link

Editing text from #9

jaipurstories-3

Questions/Notes:
• This is shamelessly ripped off from Tumblr
• Allows user to edit text, font, font size, font style (bold, italic), and font color (not shown)
• Q: Will we allow users to adjust the font type/size/color for things like labels on form fields?
• Need to decide our defaults for type size, color, etc.

@thisandagain
Copy link
Contributor Author

Really great start, though I'd like to see an MUP (Minimum Useful Product) version of the configuration options for this component as well. I'm a little nervous about the touch target sizes for some of the configuration options: any thoughts on what we might want to spec as a minimum touch target size for ourselves? The minimum size is 44px (88px retina) for iOS and 34px for Windows Phone.

My recommendation would be to err towards 44px as per the lower quality digitizers on some of these devices.

@mhanratty
Copy link

MUP:
• Ability to change text
• Ability to change text color
• Ability to delete brick

Nice to have:
• Ability to change font
• WYSIWYG: Ability to preview text in edit screen and see color, font changes applied

Option 1: MUP. Color and font selection happens on a second screen.
text-option1-dropdowns

Option 2: Nice to have. WYSIWYG editing of text. Color and font options can be selected in a bottom menu where keyboard appears for text editing. Simplified version of previous design with touch targets taken into account.
text-option2-bottommenu

@thisandagain
Copy link
Contributor Author

Totally awesome. What do you think about dropping the text labels on the color list and just doing a grid of colors?

@thisandagain
Copy link
Contributor Author

@mhanratty
Copy link

So Option 1 but replace the text color selection screen with grid of colors kind like this - http://mhanratty.github.io/marketplaceux-usercollections/projectSpecsEditCollection.html#editcollectionbackgroundmobile

Also, need to figure out colors. Will we just use the palette you made for now?

@thisandagain
Copy link
Contributor Author

Yup! Sure... let's start with that and then we can kick out some compliments programmagically:
https://github.com/Fooidge/PleaseJS

@mhanratty
Copy link

Comment here or in redpen: https://redpen.io/ej22fa711a22989a87

Questions/Notes:
• Not 100% on the "dropdown" element I'm using to indicate current color and allow the user to select a new one. Could also show color in a box with a button next to it to choose a color.

make - edit text 2x

@mhanratty
Copy link

Hello World version of text editing:

https://redpen.io/ej22fa711a22989a87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants