Skip to content
This repository has been archived by the owner on Mar 15, 2018. It is now read-only.

Commit

Permalink
Fixed lock polling on reviewers queues (bug 801967)
Browse files Browse the repository at this point in the history
  • Loading branch information
robhudson committed Oct 24, 2012
1 parent 106e513 commit 22fb057
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
18 changes: 9 additions & 9 deletions media/js/zamboni/editors.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ $(function() {
$me.hide();
$me.next().show();
$me.parents('tr').next().show();
}
};

var hide_comments = function(e) {
e.preventDefault();
var $me = $(e.target);
$me.hide();
$me.prev().show();
$me.parents('tr').next().hide();
}
};


$('a.show').click(show_comments);
Expand Down Expand Up @@ -47,7 +47,7 @@ $(function() {
if ($("#addon[data-id], #persona[data-id]").exists()) {
$("#addon .icon").click(function() {
window.location.hash = "id=" + $("#addon, #persona").attr("data-id");
})
});
}
});

Expand Down Expand Up @@ -123,7 +123,7 @@ function initReviewActions() {
$('.files .install').click(_pd(function(){
var $this = $(this),
installer = $this.is('[data-type="search-tools"]') ? z.installSearch : z.installAddon;
installer($this.text(), $this.attr('href'), "")
installer($this.text(), $this.attr('href'), "");
}));


Expand Down Expand Up @@ -246,8 +246,8 @@ function initDailyMessage(doc) {
function initQueue() {
var url = $('#addon-queue').attr('data-url'),
addon_ids = $.map($('.addon-row'), function(el) {
return $(el).attr('data-addon');
});
return $(el).attr('data-addon');
});
if(!(('localStorage' in window) && window.localStorage['dont_poll'])) {
(function checkCurrentlyViewing() {
$.post(url, {'addon_ids': addon_ids.join(',')}, function(data) {
Expand Down Expand Up @@ -286,7 +286,7 @@ function initQueue() {
}
});
return true;
}
};

$('.addon-version-notes a').each(function(i, el) {
$(pop).popup(el, { pointTo: el, callback: loadNotes, width: 500});
Expand Down Expand Up @@ -349,14 +349,14 @@ function initScrollingSidebar() {
function initPerformanceStats() {
var container = $('#monthly'),
groups = {'usercount': $('#reviews_user').text(),
'teamavg': gettext('Average Reviews')}
'teamavg': gettext('Average Reviews')};

/* View Other User Stats */
$('#select_user').change(function(){
var $this = $(this),
user = $this.val();

if(user != "") {
if(user !== "") {
window.location.href = $this.attr('data-url') + user;
}
});
Expand Down
1 change: 1 addition & 0 deletions mkt/reviewers/templates/reviewers/queue.html
Original file line number Diff line number Diff line change
Expand Up @@ -139,5 +139,6 @@ <h3>
{% endblock %}

{% block js %}
{{ js('zamboni/editors') }}
{{ js('mkt/reviewers') }}
{% endblock %}

0 comments on commit 22fb057

Please sign in to comment.