make the search form lazier and cachier

apps/search/forms.py

@@ -110,8 +110,9 @@ class _SearchForm(forms.Form):
         advanced = forms.BooleanField(widget=forms.HiddenInput)
 
         # Attach these to the form for usage in the template.
-        app_versions = get_app_versions()
+        get_app_versions = staticmethod(get_app_versions)
         top_level_cat = dict(top_level)
+        queryset = AppVersion.objects.filter(id__in=amo.APP_IDS)
 
         # TODO(jbalogh): when we start using this form for zamboni search, it
         # should check that the appid and lver match up using app_versions.

apps/search/helpers.py

@@ -0,0 +1,8 @@
+import jingo
+
+from . import forms
+
+
+@jingo.register.function
+def SearchForm(request):
+    return forms.SearchForm(request)

settings.py

@@ -127,7 +127,6 @@
     'amo.context_processors.app',
     'amo.context_processors.i18n',
     'amo.context_processors.global_settings',
-    'search.context_processors.search_form',
 )
 
 ROOT_URLCONF = '%s.urls' % ROOT_PACKAGE

templates/search.html

@@ -1,3 +1,5 @@
+{% set search_form = SearchForm(request) %}
+{% cache search_form.queryset %}
 {% set show_advanced = search_form.advanced.data == 'on' %}
 <div class="search-form expanded-search-form {% if show_advanced %}expanded{% endif %}">
   <form method="get" id="search-form" action="{{ url('search.search') }}">
@@ -60,8 +62,9 @@
         </div>
       </fieldset>
       <span id="search-data"
-        data-appversions="{{ search_form.app_versions|json }}"></span>
+        data-appversions="{{ search_form.get_app_versions()|json }}"></span>
       {{ search_form.advanced|safe }}
     </div> {# advanced-search #}
   </form>
 </div>
+{% endcache %}