This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
content ratings ES result reverse-compat with old ES results (bug 943371) #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| body = mkt.ratingsbodies.dehydrate_ratings_body( | ||
| mkt.ratingsbodies.RATINGS_BODIES[int(rating['body'])]) | ||
| except TypeError: | ||
| # Work with old ES mapping where before we just stored the whole |
There was a problem hiding this comment.
could we just return {} instead? Fireplace can handle that. and this is for legacy format anyway.
There was a problem hiding this comment.
Alright, since they'll have the indexes refreshed at some point.
|
r+wc |
ngokevin
added a commit
that referenced
this pull request
Nov 26, 2013
content ratings ES result reverse-compat with old ES results (bug 943371)
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gracefully fail or recover when met with old ES results.