This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
show warnings if no origin or not packaged (bug 1027397) #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% elif not addon.origin %} | ||
| <div class="island notification-box"> | ||
| {% trans origin='https://developer.mozilla.org/en-US/Apps/Build/Manifest#origin' %} | ||
| You have no <a href="{{ origin }}">origin</a> defined in your manifest, this means that receipts cannot be properly verified. |
There was a problem hiding this comment.
should the whole <a> link be passed in as a variable? If not, maybe add a L10n comment that origin should not be localized
There was a problem hiding this comment.
nit: I think this would read better as "You must define an origin in your manifest so that receipts can be verified properly."
There was a problem hiding this comment.
like the rewording, this is how urls are normally localised in trans in the rest of the site
|
r+wc |
andymckay
pushed a commit
that referenced
this pull request
Jun 20, 2014
show warnings if no origin or not packaged (bug 1027397)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.