This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Remove rocketfuel code, keep a small compatibility layer for the API (bug 1106586, bug 1058292) #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
force-pushed
the
remove-rocketfuel
branch
from
125b0d7
to
b965b6e
Compare
| from .managers import PublicCollectionsManager | ||
|
|
||
|
|
||
| class Collection(ModelBase): |
There was a problem hiding this comment.
You're removing the model but I don't see a migration to remove any of the database contents or tables.
There was a problem hiding this comment.
Ah, yes, forgot to do that. Added.
|
r+wc. I'd like to see the migration first. |
|
Some interesting test failures, looking into them now. |
diox
force-pushed
the
remove-rocketfuel
branch
2 times, most recently
from
7c83c7e
to
0649803
Compare
|
Fixed test failure, added migration and squashed commits. |
| @@ -0,0 +1,3 @@ | |||
| DROP TABLE `app_collections_curators`; | |||
| DROP TABLE `app_collection_membership`; | |||
| DROP TABLE `app_collections`; | |||
There was a problem hiding this comment.
Do you need to worry about the translations fields that are related here?
There was a problem hiding this comment.
No, it works, it'll just leave orphaned translations, but we should have something else to clean them up.
|
Looks good to me. |
diox
force-pushed
the
remove-rocketfuel
branch
2 times, most recently
from
2a705d6
to
2c0379e
Compare
…(bug 1106586, bug 1058292)
diox
added a commit
that referenced
this pull request
Dec 8, 2014
Remove rocketfuel code, keep a small compatibility layer for the API (bug 1106586, bug 1058292)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1106586
https://bugzilla.mozilla.org/show_bug.cgi?id=1058292