Remove rocketfuel code, keep a small compatibility layer for the API (bug 1106586, bug 1058292)

migrations/645-collection-backfill-slugs.py

@@ -1,7 +1,2 @@
-from mkt.collections.models import Collection
-
-
 def run():
-    """Backfill slugs."""
-    for c in Collection.objects.all():
-        c.save()
+    return

migrations/876-remove-rocketfuel-collections.sql

@@ -0,0 +1,3 @@
+DROP TABLE `app_collections_curators`;
+DROP TABLE `app_collection_membership`;
+DROP TABLE `app_collections`;

mkt/api/tests/nose.cfg

@@ -17,10 +17,6 @@ tests=mkt.abuse.tests.test_views,
       mkt.api.tests.test_urls,
       mkt.api.tests.test_views,
       mkt.comm.tests.test_views,
-      mkt.collections.tests.test_authorization,
-      mkt.collections.tests.test_fields,
-      mkt.collections.tests.test_serializers,
-      mkt.collections.tests.test_views,
       mkt.developers.tests.test_api_payments,
       mkt.developers.tests.test_views_api,
       mkt.features.tests.test_serializers,

mkt/api/tests/test_urls.py

@@ -78,11 +78,9 @@ class TestAPIv1URLs(BaseTestAPIVersionURLs, amo.tests.TestCase):
 
     def test_collections(self):
         """
-        Tests the v1 half of a move of the collection endpoints from:
-        - v1: /rocketfuel/collections/
-        - v2: /feed/collections/
+        Tests the v1 endpoints removed in v2 still work with v1.
         """
-        self.assertViewName('/rocketfuel/collections/', 'CollectionViewSet')
+        self.assertViewName('/apps/search/featured/', 'FeaturedSearchView')
 
 
 class TestAPIv2URLs(BaseTestAPIVersionURLs, amo.tests.TestCase):
@@ -94,8 +92,6 @@ class TestAPIv2URLs(BaseTestAPIVersionURLs, amo.tests.TestCase):
 
     def test_collections(self):
         """
-        Tests the v2 half of a move of the collection endpoints from:
-        - v1: /rocketfuel/collections/
-        - v2: /feed/collections/
+        Tests the v2 endpoints removal.
         """
-        self.assertView404('/rocketfuel/collections/')
+        self.assertView404('/apps/search/featured/')

mkt/api/v1/urls.py

@@ -5,12 +5,11 @@
 
 from mkt.abuse.urls import api_patterns as abuse_api_patterns
 from mkt.account.urls import api_patterns as account_api_patterns
-from mkt.api.base import SubRouter, SubRouterWithFormat
+from mkt.api.base import SubRouter
 from mkt.api.views import (CarrierViewSet, CategoryViewSet,
                            error_reporter, ErrorViewSet, PriceTierViewSet,
                            PriceCurrencyViewSet, RefreshManifestViewSet,
                            RegionViewSet, site_config)
-from mkt.collections.views import CollectionImageViewSet, CollectionViewSet
 from mkt.comm.urls import api_patterns as comm_api_patterns
 from mkt.developers.urls import dev_api_patterns, payments_api_patterns
 from mkt.features.views import AppFeaturesList
@@ -22,13 +21,6 @@
 from mkt.submit.views import PreviewViewSet, StatusViewSet, ValidationViewSet
 from mkt.webapps.views import AppTagViewSet, AppViewSet, PrivacyPolicyViewSet
 
-rocketfuel = SimpleRouter()
-rocketfuel.register(r'collections', CollectionViewSet,
-                    base_name='collections')
-
-subcollections = SubRouterWithFormat()
-subcollections.register('image', CollectionImageViewSet,
-                        base_name='collection-image')
 
 apps = SimpleRouter()
 apps.register(r'preview', PreviewViewSet, base_name='app-preview')
@@ -70,8 +62,6 @@
     url(r'^services/', include(services.urls)),
     url(r'^services/config/site/', site_config, name='site-config'),
     url(r'^fireplace/report_error/\d*', error_reporter, name='error-reporter'),
-    url(r'^rocketfuel/', include(rocketfuel.urls)),
-    url(r'^rocketfuel/collections/', include(subcollections.urls)),
     url(r'^apps/', include('mkt.versions.urls')),
     url(r'^apps/', include('mkt.ratings.urls')),
     url(r'^apps/features/', AppFeaturesList.as_view(),