This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Bug 1093210 move newrelic to a separate file #3039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
graingert
force-pushed
the
uninline-newrelic-for-csp
branch
from
0450deb
to
0766d6d
Compare
graingert
force-pushed
the
uninline-newrelic-for-csp
branch
from
0766d6d
to
81595d4
Compare
| @@ -27,9 +27,11 @@ | |||
| <link rel="dns-prefetch" href="//www.google-analytics.com"> | |||
| <link rel="dns-prefetch" href="//stats.g.doubleclick.net"> | |||
|
|
|||
| {{ newrelic_header()|safe if repo == 'fireplace' }} | |||
| {% if repo == 'fireplace' %} | |||
| <script type="text/javascript" src="{{ media('js/lib/newrelic.js') }}" id='newrelic-footer'></script> | |||
There was a problem hiding this comment.
is this id on the correct element?
|
Per discussion on the bug, I don't think we should follow that approach. Instead, we should look into integrating newrelic with our js bundles. See https://bugzilla.mozilla.org/show_bug.cgi?id=1093210 comment 6 to 9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock https://bugzilla.mozilla.org/show_bug.cgi?id=1093210