This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
remove preload test plan feature (bug 1164223) #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "note": "Submission process for preinstalled apps." | ||
| }, | ||
| "model": "waffle.switch", | ||
| "pk": 48 |
There was a problem hiding this comment.
Consider a migration to remove the waffle switch as well, maybe ?
There was a problem hiding this comment.
i added one, not sure if i did it right though
|
travis found a bunch of orphaned imports |
ngokevin
force-pushed
the
rmpreload
branch
3 times, most recently
from
398cecc
to
f77a52e
Compare
|
|
||
|
|
||
| def remove_preload_waffle(apps, schema_editor): | ||
| # We can't import the Person model directly as it may be a newer |
There was a problem hiding this comment.
got caught red-handed copying from the docs
|
@diox re-r? added a migration to wipe the table, don't need it |
|
r+ |
ngokevin
added a commit
that referenced
this pull request
Nov 11, 2015
remove preload test plan feature (bug 1164223)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.