add kuma ATTACHMENT_ORIGIN setting #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
changed the title
This was referenced Oct 25, 2017
jwhitlock
suggested changes
Oct 26, 2017
There was a problem hiding this comment.
👍 with one issue around blank environments
I tested on the prod environments by modifying make k8s-web to just run j2. I then tried with the stage environment, which still had KUMA_ATTACHMENT_ORIGIN defined from prod. I then ran export KUMA_ATTACHMENT_ORIGIN= and tried again, and got a blank value for ATTACHMENT_ORIGIN.
Also, I just remembered we had a staging environment where we could test this stuff.
| @@ -33,6 +33,8 @@ | |||
| value: "{{ KUMA_ALLOWED_HOSTS }}" | |||
| - name: ATTACHMENT_HOST | |||
| value: {{ KUMA_ATTACHMENT_HOST }} | |||
| - name: ATTACHMENT_ORIGIN | |||
| value: {{ KUMA_ATTACHMENT_ORIGIN | default(KUMA_ATTACHMENT_HOST) }} | |||
There was a problem hiding this comment.
Let's use:
value: {{ KUMA_ATTACHMENT_ORIGIN | default(KUMA_ATTACHMENT_HOST, True) }}
This way, a blank string also defaults to KUMA_ATTACHMENT_HOST
There was a problem hiding this comment.
Great catch! That issue has bit me in the past with these configs, so I should have been more vigilant about it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to mdn/kuma#4479.