Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldError on /admin/base/job/add/ #1220

Closed
jgmize opened this issue Nov 1, 2019 · 1 comment · Fixed by #1221
Closed

FieldError on /admin/base/job/add/ #1220

jgmize opened this issue Nov 1, 2019 · 1 comment · Fixed by #1221

Comments

@jgmize
Copy link
Contributor

jgmize commented Nov 1, 2019

https://sentry.prod.mozaws.net/operations/snippets/issues/6453618/?query=is:unresolved

"'completed_on' cannot be specified for Job model form as it is a non-editable field. Check fields/fieldsets/exclude attributes of class JobAdmin."
@triage-new-issues triage-new-issues bot added Triage and removed Triage labels Nov 1, 2019
@jgmize jgmize changed the title FieldError/admin/base/job/add/ FieldError on /admin/base/job/add/ Nov 1, 2019
@jgmize jgmize mentioned this issue Nov 1, 2019
Merged
jgmize added a commit that referenced this issue Nov 1, 2019
@jgmize
Remove completed_on from admin fields to fix #1220
d423fc8
@jgmize jgmize mentioned this issue Nov 1, 2019
Merged
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Nov 4, 2019
@glogiotatidis
Revert "Remove completed_on from admin fields to fix mozmeao#1220"
5556c8a 
This reverts commit d423fc8.

and fixes adds completed_on to readonly_fields to make the reverted commit not
required.
@glogiotatidis glogiotatidis mentioned this issue Nov 4, 2019
Open
@glogiotatidis
Copy link
Contributor

Thanks for quickly fixing this Josh. Created an issue to add a list of tests to catch errors like this before they hit prod. #1223

glogiotatidis added a commit that referenced this issue Nov 4, 2019
@glogiotatidis
Merge pull request #1222 from glogiotatidis/completed_on
ca4a3da 
Revert "Remove completed_on from admin fields to fix #1220"
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Nov 19, 2019
@glogiotatidis
[Fix mozmeao#1220] Remove OrderedDict
4df56db
glogiotatidis added a commit that referenced this issue Nov 28, 2019
@glogiotatidis
Merge pull request #1232 from glogiotatidis/issue-1220-remove-ordered…
dc1a7be 
…dict

[Fix #1220] Remove OrderedDict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove completed_on from admin fields mozmeao/snippets-service
2 participants
@jgmize @glogiotatidis