Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldError on /admin/base/job/add/ #1220

Closed
jgmize opened this issue Nov 1, 2019 · 1 comment · Fixed by #1221

Comments

@jgmize
Copy link
Member

@jgmize jgmize commented Nov 1, 2019

https://sentry.prod.mozaws.net/operations/snippets/issues/6453618/?query=is:unresolved

"'completed_on' cannot be specified for Job model form as it is a non-editable field. Check fields/fieldsets/exclude attributes of class JobAdmin."

@triage-new-issues triage-new-issues bot added Triage and removed Triage labels Nov 1, 2019
@jgmize jgmize changed the title FieldError/admin/base/job/add/ FieldError on /admin/base/job/add/ Nov 1, 2019
jgmize added a commit that referenced this issue Nov 1, 2019
@jgmize jgmize closed this in #1221 Nov 1, 2019
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Nov 4, 2019
This reverts commit d423fc8.

and fixes adds completed_on to readonly_fields to make the reverted commit not
required.
@glogiotatidis

This comment has been minimized.

Copy link
Member

@glogiotatidis glogiotatidis commented Nov 4, 2019

Thanks for quickly fixing this Josh. Created an issue to add a list of tests to catch errors like this before they hit prod. #1223

glogiotatidis added a commit that referenced this issue Nov 4, 2019
Revert "Remove completed_on from admin fields to fix #1220"
glogiotatidis added a commit to glogiotatidis/snippets-service that referenced this issue Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.