Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check status of PR #10

Closed
cconcolato opened this issue Jan 31, 2018 · 3 comments
Closed

Check status of PR #10

cconcolato opened this issue Jan 31, 2018 · 3 comments

Comments

@cconcolato
Copy link
Collaborator

We need to add a TravisCI script that checks when someone makes a PR to make sure that the PR cannot be merged if one of the following criteria applies:

  • it's touching the JS or HTML
  • it's removing something from a CSV
  • there's already an entry with that value in the CSV

The TravisCI integration is easy. The writing of the checks needs work.

@dwsinger
Copy link
Collaborator

Except that we have an example here where they are deliberately updating/clarifying an existing prior entry that they registered...

@cconcolato
Copy link
Collaborator Author

I hadn't noticed. At least, the fact that the merge is not possible would raise the question. We probably can merge by overriding the script result.

@dwsinger
Copy link
Collaborator

dwsinger commented Jul 9, 2019

We handle manually for now

@dwsinger dwsinger closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants