This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Support type definitions for DynamicMdcField Patterns #197
+643
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder which doesn't call base class build() method - Added missing setting of dynamicFieldTypes in *.log4j.GelfLogAppender - Implemented log4j test
- Modified *.log4j2.GelfLogAppender to accept new xml attribute - Started to implement tests for log4j2 but face issue there
- Added setting of dynamicFiledTypes in *.logback.GelfLogbackAppender - Added tests for logback
|
Ok, the problem with the test reported on the issue only occurred when executed in IntelliJ, but now they pass except the Travis Java 11 tests. |
- Added unit tests for GelfDynamicMdcFieldType log4j2 model
|
The JDK 11 test fails during initialization. Seems something is wrong with the |
|
Any news? |
mp911de
changed the title
mp911de
suggested changes
May 16, 2019
src/main/java/biz/paluch/logging/gelf/GelfMessageAssembler.java
Outdated
Show resolved
Hide resolved
src/main/java/biz/paluch/logging/gelf/GelfMessageAssembler.java
Outdated
Show resolved
Hide resolved
src/main/java/biz/paluch/logging/gelf/GelfMessageAssembler.java
Outdated
Show resolved
Hide resolved
src/main/java/biz/paluch/logging/gelf/log4j2/GelfDynamicMdcFieldType.java
Show resolved
Hide resolved
src/main/java/biz/paluch/logging/gelf/log4j2/GelfDynamicMdcFieldType.java
Outdated
Show resolved
Hide resolved
src/main/java/biz/paluch/logging/gelf/log4j2/GelfLogAppender.java
Outdated
Show resolved
Hide resolved
src/test/java/biz/paluch/logging/gelf/GelfDynamicMdcFieldTypeUnitTests.java
Outdated
Show resolved
Hide resolved
src/test/java/biz/paluch/logging/gelf/GelfDynamicMdcFieldTypeUnitTests.java
Outdated
Show resolved
Hide resolved
|
Ping. Any update? |
- Added overload to support setting via pattern instance additionally to setting via string - unit test switched to junit4 because cannot use lambdas when language level is 1.6
|
Sorry for the late answer. I have implemented the changes |
mp911de
pushed a commit
that referenced
this pull request
Jun 25, 2019
We now support dynamic MDC field typing using Regex-based pattern rules so field types can be assigned dynamically. Original pull request: #197.
|
Thanks a lot. That's squashed, merged and polished now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Issue #116