Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer works with Visual Studio 2017 #35

Closed
emptyVoid opened this issue Dec 5, 2017 · 4 comments
Closed

No longer works with Visual Studio 2017 #35

emptyVoid opened this issue Dec 5, 2017 · 4 comments

Comments

@emptyVoid
Copy link

I've just updated to VS 15.5 (toolset 14.12), and no longer able to build projects which use the variant.
Here're the errors (in case it helps):

C3528	'Is': the number of elements in this pack expansion does not match the number of elements in 'Js'	...\mpark\variant.hpp	575
C2672	'mpark::detail::visitation::base::make_farray': no matching overloaded function found	cvtest	...\mpark\variant.hpp	574
C2893	Failed to specialize function template 'mpark::lib::cpp14::array<std::common_type<std::decay<Fs>::type...>::type,sizeof...(Fs)> mpark::detail::visitation::base::make_farray(Fs &&...)'	...\mpark\variant.hpp	575
C2672	'mpark::detail::visitation::base::at': no matching overloaded function found	...\mpark\variant.hpp	629
C2784	'const remove_all_extents<T>::type &mpark::detail::visitation::base::at(const mpark::lib::cpp14::array<T,N> &,::size_t,Is...)': could not deduce template argument for 'const mpark::lib::cpp14::array<T,N> &' from 'void'	...\mpark\variant.hpp	633
C2780	'const T &mpark::detail::visitation::base::at(const T &)': expects 1 arguments - 2 provided	...\mpark\variant.hpp	633
@mpark
Copy link
Owner

mpark commented Dec 7, 2017

Thanks for the report! I'll look into this today.

@ltjax
Copy link

ltjax commented Dec 9, 2017

I got the same error! Any idea what's causing this?
I tried with Tag v1.2.0 and today's master

@mpark
Copy link
Owner

mpark commented Dec 9, 2017

It seems like it's having trouble with the cartesian product generation here: https://github.com/mpark/variant/blob/master/include/mpark/variant.hpp#L574-L575

I'll have to play with whether I need to reformulate this for MSVC or if there's some way to coax it to understand it.

@mpark
Copy link
Owner

mpark commented Dec 11, 2017

Closed by 2bb35f1

@mpark mpark closed this as completed Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants