alia/execute fails silently with extraneous keys in the connection map passed to alia/cluster used in alia/connection

[Reefersleep]

Hello mpenet

I'm in doubt about whether this is a known issue or even accepted, known behavior.

I've experienced problems with the connection generated by alia/connection using a cluster generated by alia/clustercalled with a map that includes keys in addition to the ones generated in the documentation. Nothing seems to go wrong at connection time, but at alia/execute time, exceptions occur. (Sorry, don't recall exactly which, and the problem is fixed now and the project is moving on).

It would have been nice for cluster or connection to validate the map passed in and throw upon extraneous keys, rather than failing silently and causing errors later on - this made it much harder to figure out the error.

Kind regards
Reefersleep

[mpenet]

Hi,

I can make it so that extra unknown keys will not cause errors, but I will not do strict validation of the keys. You can already use the specs provided if you want to make sure the correct keys hold the correct values but it will not check extra keys by itself (some spec based libraries can do that if you want to do so).

[mpenet]

By the way you can patch this at runtime with the following:

(defmethod qbits.alia.cluster-options/set-cluster-option! :default
  ;; let unknown keys flow, or throw 
  [k builder x] 
  ;;  return `builder` to let it flow
  ;;  or throw: 
    (throw (ex-info "Unknown config key" {:type ::unknown-key :key k :value x}))
) 

[Reefersleep]

Cheers Max. Being robust towards extra keys (I guess by ignoring them) accomplishes the same goal in my eyes, and is in the spirit of Clojure in general :) As I see it, at least.

And thanks for the tip!

alia and hayt, are great. so thanks a lot for them! :D

[mpenet]

I agree.
I commited a change that let extra keys flow earlier. I ll release a new version tomorrow with the change.

Thanks for the report!

[mpenet]

available on clojars as 4.3.0 (why the jump from 4.0.2 to 4.3.0 you might ask? "Lack of coffee" before updating it would be my answer).

[Reefersleep]

Awesome!

Are you also actively developing hayt? I think I've been missing some CQL syntax equivalents a couple of times. Should either create issues or PRs once I remember what they were, if it's an active project?

[mpenet]

It's active, but I am not using cassandra as much as I used to right now so it's lacking some love. I would very much welcome prs to keep it up to date, it's fairly easy to extend with the new stuff I expect.