CSRF vulnerability in Web UI #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break any 3rd party Web UI extensions which try to process POSTs. They will need to update their forms to include the same hidden token input. |
|
wow, nice changes! 🎉 |
|
No reason. Actually I should have pulled the entire line out: |
|
okay, I understand, thanks :) |
mperham
added a commit
that referenced
this pull request
Jul 6, 2015
mkdynamic
added a commit
to delighted/sidekiq
that referenced
this pull request
Jul 15, 2015
mkdynamic
added a commit
to delighted/sidekiq-failures
that referenced
this pull request
Jul 15, 2015
tijmenb
added a commit
to alphagov/collections-publisher
that referenced
this pull request
Feb 4, 2016
This commit upgrades Sidekiq to 3.5.4, the latest version in the 3.X series (4.0 has come out a few months ago). It is necessary to upgrade because there are a couple of vulnerabilities reported in 2.X. The issues concerns these issues: - sidekiq/sidekiq#2422 - sidekiq/sidekiq#2330 - sidekiq/sidekiq#2309 As mentioned in the upgrade guide[1], we've upgradedA the Airbrake gem as well. Other items in the upgrade guide are not applicable. [1] https://github.com/mperham/sidekiq/blob/master/3.0-Upgrade.md
carvil
pushed a commit
to alphagov/content-tagger
that referenced
this pull request
Jul 20, 2016
This commit upgrades Sidekiq to 3.5.4, the latest version in the 3.X series (4.0 has come out a few months ago). It is necessary to upgrade because there are a couple of vulnerabilities reported in 2.X. The issues concerns these issues: - sidekiq/sidekiq#2422 - sidekiq/sidekiq#2330 - sidekiq/sidekiq#2309 As mentioned in the upgrade guide[1], we've upgradedA the Airbrake gem as well. Other items in the upgrade guide are not applicable. [1] https://github.com/mperham/sidekiq/blob/master/3.0-Upgrade.md
chrismytton
added a commit
to everypolitician/webhook-manager
that referenced
this pull request
Sep 28, 2016
This fixes the following vulnerabilities that bundler-audit warns us about: Name: sidekiq Version: 3.3.4 Advisory: 125675 Criticality: Unknown URL: sidekiq/sidekiq#2422 Title: Sidekiq Gem for Ruby Multiple Unspecified CSRF Solution: upgrade to >= 3.4.2 Name: sidekiq Version: 3.3.4 Advisory: 125676 Criticality: Unknown URL: sidekiq/sidekiq#2330 Title: Sidekiq Gem for Ruby web/views/queue.erb CurrentMessagesInQueue Element Reflected XSS Solution: upgrade to >= 3.4.0 Name: sidekiq Version: 3.3.4 Advisory: 125678 Criticality: Unknown URL: sidekiq/sidekiq#2309 Title: Sidekiq Gem for Ruby web/views/queue.erb msg.display_class Element XSS Solution: upgrade to >= 3.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form POSTs don't verify an authenticity token so it's possible to do bad stuff. Fix incoming...