Force MultiJson to NOT symbolize keys #697
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your load_json method must use your explicit MultiJson decoder options, in your case :symbolize_keys => false (you're using string keys)
Point is, that if you don't do it, then your gem will not work as expected. For example in your sinatra monitoring app, your slim templates are using msg['class'], msg['args] etc... but if in project where sidekiq is required will be global MultiJson configuration or global configuration for particular JSON gem, like:
Your gem will not work at all. So you'll see empty queues http://cl.ly/image/0X2q1S232q1B and workers will not work at all as well, simply they are expecting 'string' keys...